Packaging scripts for Mac and Linux Cloud Print Drivers.

Packaging scripts for Mac and Linux Cloud Print Drivers.
Spun off from http://codereview.chromium.org/7599018/ to facilitate try server usage.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97100

[Scott Byer, 2011-08-16 23:31:25]

+maruel for additional script checking, feel free to forward on.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
File cloud_print/virtual_driver/posix/linux_packaging/build.sh (right):

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:15: cd $SCRIPTDIR
move this up to after SCRIPTDIR assignment, to keep them together as an idiom.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:17: ##clean up any old
data completely
nit:extra hash, no space

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:26: 
nit: extra line

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:28: #Set up the
required directory structure
nit: here and elsewhere, space after hash

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:36: mv postinst
debian/DEBIAN
Aren't these going to want to be copies instead? What happens if I invoke the
script twice in a row (e.g., not a clobber build)?

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
File cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh (right):

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:21: mv GCP-driver
package_root/usr/libexec/cups/backend
Do these want to be moves or copies? What if I run the script twice in a row
(repeat a build)?

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:28: -d
GCP-Virtual-Driver.pmdoc -t GCP-virtual-driver
indent 2 spaces on a continuation

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:30: 
nit: extra lines. Be consistent with line spacing.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:47: 
nit: extra lines

[abeera, 2011-08-16 23:55:03]

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
File cloud_print/virtual_driver/posix/linux_packaging/build.sh (right):

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:15: cd $SCRIPTDIR
On 2011/08/16 23:31:25, Scott Byer wrote:
> move this up to after SCRIPTDIR assignment, to keep them together as an idiom.

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:17: ##clean up any old
data completely
On 2011/08/16 23:31:25, Scott Byer wrote:
> nit:extra hash, no space

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:26: 
On 2011/08/16 23:31:25, Scott Byer wrote:
> nit: extra line

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:28: #Set up the
required directory structure
On 2011/08/16 23:31:25, Scott Byer wrote:
> nit: here and elsewhere, space after hash

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
File cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh (right):

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:28: -d
GCP-Virtual-Driver.pmdoc -t GCP-virtual-driver
On 2011/08/16 23:31:25, Scott Byer wrote:
> indent 2 spaces on a continuation

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:30: 
On 2011/08/16 23:31:25, Scott Byer wrote:
> nit: extra lines. Be consistent with line spacing.

Done.

http://codereview.chromium.org/7670010/diff/1/cloud_print/virtual_driver/posi...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:47: 
On 2011/08/16 23:31:25, Scott Byer wrote:
> nit: extra lines

Done.

[M-A Ruel, 2011-08-17 00:02:03]

lgtm

http://codereview.chromium.org/7670010/diff/4002/cloud_print/virtual_driver/p...
File cloud_print/virtual_driver/posix/linux_packaging/build.sh (right):

http://codereview.chromium.org/7670010/diff/4002/cloud_print/virtual_driver/p...
cloud_print/virtual_driver/posix/linux_packaging/build.sh:61: 
remove extra line

http://codereview.chromium.org/7670010/diff/4002/cloud_print/virtual_driver/p...
File cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh (right):

http://codereview.chromium.org/7670010/diff/4002/cloud_print/virtual_driver/p...
cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh:48: 
remove extra line

[commit-bot: I haz the power, 2011-08-17 00:08:58]

Presubmit check for 7670010-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
cloud_print/virtual_driver/posix/linux_packaging/build.sh,cloud_print/virtual_driver/posix/mac_packaging/build_mac.sh

[Scott Byer, 2011-08-17 00:18:44]

LGTM

[commit-bot: I haz the power, 2011-08-17 05:56:40]

Change committed as 97100