Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 7670008: Fix cursor in fullscreen pepper (Closed)

Created:
9 years, 4 months ago by piman
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix cursor in fullscreen pepper BUG=chromium-os:14322 TEST=Pepper Flash on Youtube, go full screen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97088

Patch Set 1 #

Total comments: 2

Patch Set 2 : alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/fullscreen_container.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
9 years, 4 months ago (2011-08-16 22:18:25 UTC) #1
Daniel Erat
LGTM http://codereview.chromium.org/7670008/diff/1/webkit/plugins/ppapi/fullscreen_container.h File webkit/plugins/ppapi/fullscreen_container.h (right): http://codereview.chromium.org/7670008/diff/1/webkit/plugins/ppapi/fullscreen_container.h#newcode12 webkit/plugins/ppapi/fullscreen_container.h:12: struct WebCursorInfo; nit: alphabetize?
9 years, 4 months ago (2011-08-16 23:09:45 UTC) #2
piman
http://codereview.chromium.org/7670008/diff/1/webkit/plugins/ppapi/fullscreen_container.h File webkit/plugins/ppapi/fullscreen_container.h (right): http://codereview.chromium.org/7670008/diff/1/webkit/plugins/ppapi/fullscreen_container.h#newcode12 webkit/plugins/ppapi/fullscreen_container.h:12: struct WebCursorInfo; On 2011/08/16 23:09:45, Daniel Erat wrote: > ...
9 years, 4 months ago (2011-08-16 23:33:51 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-17 02:45:48 UTC) #4
Change committed as 97088

Powered by Google App Engine
This is Rietveld 408576698