Issue 7670007: Revert 96969 - Implement SyncableServices in TemplateURLService. Add related unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7670007: Revert 96969 - Implement SyncableServices in TemplateURLService. Add related unittests. (Closed)

Created:
9 years, 4 months ago by michaeln

Modified:
9 years, 4 months ago

Reviewers:
SteveT

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 96969 - Implement SyncableServices in TemplateURLService. Add related unittests. TEST=Ensure all TemplateURLService related unit tests pass. BUG=15548 Review URL: http://codereview.chromium.org/7566036 TBR=stevet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97035

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1530 lines)			Patch
M	chrome/browser/search_engines/template_url.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.h	View	9 chunks	+1 line, -120 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.cc	View	16 chunks	+7 lines, -409 lines	0 comments	Download
D	chrome/browser/search_engines/template_url_service_sync_unittest.cc	View	1 chunk	+0 lines, -974 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_unittest.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/api/sync_change.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/api/sync_change.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM

Will recommit later once the heapbots are green