Wire experimental Flapper part two

Wire experimental Flapper part two

Since the new pepper plugin can arrive later we needed a way to
integrate better with the webkit::PluginList, unfortunately there
is still value on the PepperPluginRegistry for development use
cases.

So this change adds new plugins to both the pepper plugin lists in
the browser (in PluginService) and the renderer (in PepperPluginRegistry)
on demand.



TEST=see bug
BUG=89248
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97091

[brettw, 2011-08-16 23:28:05]

LGTM, good luck

http://codereview.chromium.org/7670003/diff/6002/chrome/browser/component_upd...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

http://codereview.chromium.org/7670003/diff/6002/chrome/browser/component_upd...
chrome/browser/component_updater/pepper_flash_component_installer.cc:113: // The
description is like "Shockwave Flash (pepper) 10.2 r154".
I think this comment shouldn't have "(pepper)" in it.

http://codereview.chromium.org/7670003/diff/6002/content/browser/plugin_servi...
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/7670003/diff/6002/content/browser/plugin_servi...
content/browser/plugin_service.cc:498: // be a latecomer, as it happens with
windows flapper. This information
can you say "pepper flash" instead of flapper here, since most people won't know
what it is.

http://codereview.chromium.org/7670003/diff/6002/content/browser/plugin_servi...
content/browser/plugin_service.cc:510: return
&ppapi_plugins_[ppapi_plugins_.size()-1];
Can you put spaces around the - here?

http://codereview.chromium.org/7670003/diff/6002/content/common/pepper_plugin...
File content/common/pepper_plugin_registry.cc (right):

http://codereview.chromium.org/7670003/diff/6002/content/common/pepper_plugin...
content/common/pepper_plugin_registry.cc:86: path.BaseName().LossyDisplayName()
: ASCIIToUTF16(name);
Can you use UTF8ToUTF16 instead? This will assert if the name isn't ascii, which
probably isn't what we want.

http://codereview.chromium.org/7670003/diff/6002/content/common/pepper_plugin...
content/common/pepper_plugin_registry.cc:116: if
(!webkit::IsPepperPlugin(webplugin_info))
No blank line before this

http://codereview.chromium.org/7670003/diff/6002/content/common/pepper_plugin...
content/common/pepper_plugin_registry.cc:171: // be a latecomer, as it happens
with windows flapper. This information
flapper -> pepper flash.