[Sync] Add support for enabling session sync remotely.

chrome/browser/sync/glue/data_type_manager_impl.h

Index: chrome/browser/sync/glue/data_type_manager_impl.h
diff --git a/chrome/browser/sync/glue/data_type_manager_impl.h b/chrome/browser/sync/glue/data_type_manager_impl.h
index 28c9751a119055212f88e36d50194432c11b7aaa..ae065d125463e6d04d454a4cf1781c6ddb3ac251 100644
--- a/chrome/browser/sync/glue/data_type_manager_impl.h
+++ b/chrome/browser/sync/glue/data_type_manager_impl.h
@@ -24,7 +24,7 @@ class SyncBackendHost;
 class DataTypeManagerImpl : public DataTypeManager {
  public:
   DataTypeManagerImpl(SyncBackendHost* backend,
-                       const DataTypeController::TypeMap& controllers);
+                      DataTypeController::TypeMap* controllers);

[Andrew T Wilson (Slow), 2011/08/22 20:30:33]

Can we make |controllers| const?

[Nicolas Zea, 2011/08/22 22:50:15]

Done.

   virtual ~DataTypeManagerImpl();
 
   // DataTypeManager interface.
@@ -36,7 +36,6 @@ class DataTypeManagerImpl : public DataTypeManager {
                                       sync_api::ConfigureReason reason);
 
   virtual void Stop();
-  virtual const DataTypeController::TypeMap& controllers();
   virtual State state();
 
  private:
@@ -77,7 +76,7 @@ class DataTypeManagerImpl : public DataTypeManager {
   SyncBackendHost* backend_;
   // Map of all data type controllers that are available for sync.
   // This list is determined at startup by various command line flags.
-  const DataTypeController::TypeMap controllers_;
+  DataTypeController::TypeMap* controllers_;

[Andrew T Wilson (Slow), 2011/08/22 20:30:33]

Should this be a const TypeMap*, and can we document who owns this? Not entirely
certain why we changed this from a reference to a ptr, other than the fact that
it's kind of weird to keep a reference to something owned by a separate object.

[Nicolas Zea, 2011/08/22 22:50:15]

It was actually a copy, not a reference before. Made it const though.

On 2011/08/22 20:30:33, Andrew T Wilson wrote:

   State state_;
   std::map<syncable::ModelType, int> start_order_;
   TypeSet last_requested_types_;