Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome_frame/test/chrome_frame_test_utils.h

Issue 7669061: Tommi: I need an owner review for the chrome frame changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fixing license issue from presubmit check Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_test_utils.h
===================================================================
--- chrome_frame/test/chrome_frame_test_utils.h (revision 98031)
+++ chrome_frame/test/chrome_frame_test_utils.h (working copy)
@@ -17,6 +17,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "base/process_util.h"
+#include "base/test/test_reg_util_win.h"
#include "base/win/registry.h"
#include "base/win/scoped_comptr.h"
@@ -285,21 +286,6 @@
// during test runs.
base::ProcessHandle StartCrashService();
-class TempRegKeyOverride {
- public:
- static const wchar_t kTempTestKeyPath[];
-
- TempRegKeyOverride(HKEY override, const wchar_t* temp_name);
- ~TempRegKeyOverride();
-
- static void DeleteAllTempKeys();
-
- protected:
- HKEY override_;
- base::win::RegKey temp_key_;
- std::wstring temp_name_;
-};
-
// Used in tests where we reference the registry and don't want to run into
// problems where existing registry settings might conflict with the
// expectations of the test.
@@ -308,9 +294,12 @@
ScopedVirtualizeHklmAndHkcu();
~ScopedVirtualizeHklmAndHkcu();
+ // Removes all overrides and deletes all temporary test keys used by the
+ // overrides.
+ void RemoveAllOverrides();
+
protected:
- scoped_ptr<TempRegKeyOverride> hklm_;
- scoped_ptr<TempRegKeyOverride> hkcu_;
+ registry_util::RegistryOverrideManager override_manager_;
};
// Attempts to kill all the processes on the current machine that were launched
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698