Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7695)

Unified Diff: chrome/installer/util/installer_state_unittest.cc

Issue 7669061: Tommi: I need an owner review for the chrome frame changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fixing license issue from presubmit check Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/product_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installer_state_unittest.cc
===================================================================
--- chrome/installer/util/installer_state_unittest.cc (revision 98031)
+++ chrome/installer/util/installer_state_unittest.cc (working copy)
@@ -13,6 +13,7 @@
#include "base/process_util.h"
#include "base/scoped_temp_dir.h"
#include "base/string_util.h"
+#include "base/test/test_reg_util_win.h"
#include "base/utf_string_conversions.h"
#include "base/version.h"
#include "base/win/registry.h"
@@ -35,6 +36,7 @@
using installer::InstallationState;
using installer::InstallerState;
using installer::MasterPreferences;
+using registry_util::RegistryOverrideManager;
class InstallerStateTest : public TestWithTempDirAndDeleteTempOverrideKeys {
protected:
@@ -343,8 +345,10 @@
HKEY root = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
EXPECT_EQ(root, installer_state.root_key());
+
{
- TempRegKeyOverride override(root, L"root_pit");
+ RegistryOverrideManager override_manager;
+ override_manager.OverrideRegistry(root, L"root_pit");
BrowserDistribution* dist = BrowserDistribution::GetSpecificDistribution(
BrowserDistribution::CHROME_BROWSER);
RegKey chrome_key(root, dist->GetVersionKey().c_str(), KEY_ALL_ACCESS);
@@ -376,7 +380,8 @@
// check results for a fresh install of single Chrome
{
- TempRegKeyOverride override(root, L"root_inst_res");
+ RegistryOverrideManager override_manager;
+ override_manager.OverrideRegistry(root, L"root_inst_res");
CommandLine cmd_line = CommandLine::FromString(L"setup.exe --system-level");
const MasterPreferences prefs(cmd_line);
InstallationState machine_state;
@@ -403,11 +408,11 @@
key.ReadValue(installer::kInstallerSuccessLaunchCmdLine, &value));
EXPECT_EQ(launch_cmd, value);
}
- TempRegKeyOverride::DeleteAllTempKeys();
// check results for a fresh install of multi Chrome
{
- TempRegKeyOverride override(root, L"root_inst_res");
+ RegistryOverrideManager override_manager;
+ override_manager.OverrideRegistry(root, L"root_inst_res");
CommandLine cmd_line = CommandLine::FromString(
L"setup.exe --system-level --multi-install --chrome");
const MasterPreferences prefs(cmd_line);
@@ -435,7 +440,6 @@
EXPECT_EQ(launch_cmd, value);
key.Close();
}
- TempRegKeyOverride::DeleteAllTempKeys();
}
// Test GetCurrentVersion when migrating single Chrome to multi
« no previous file with comments | « chrome/installer/util/install_util_unittest.cc ('k') | chrome/installer/util/product_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698