Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4804)

Unified Diff: chrome_frame/test/util_unittests.cc

Issue 7669061: Tommi: I need an owner review for the chrome frame changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Making use of scoped cleanup where it helps Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/util_unittests.cc
===================================================================
--- chrome_frame/test/util_unittests.cc (revision 97629)
+++ chrome_frame/test/util_unittests.cc (working copy)
@@ -16,7 +16,7 @@
#include "testing/gmock/include/gmock/gmock.h"
using base::win::RegKey;
-using chrome_frame_test::TempRegKeyOverride;
+using registry_util::ScopedRegistryKeyOverride;
const wchar_t kChannelName[] = L"-dev";
const wchar_t kSuffix[] = L"-fix";
@@ -31,23 +31,25 @@
class UtilTests : public testing::Test {
protected:
void SetUp() {
- TempRegKeyOverride::DeleteAllTempKeys();
+ ScopedRegistryKeyOverride::DeleteAllTempKeys();
DeleteAllSingletons();
- hklm_pol_.reset(new TempRegKeyOverride(HKEY_LOCAL_MACHINE, L"hklm_fake"));
- hkcu_pol_.reset(new TempRegKeyOverride(HKEY_CURRENT_USER, L"hkcu_fake"));
+ hklm_pol_.reset(new ScopedRegistryKeyOverride(HKEY_LOCAL_MACHINE,
+ L"hklm_fake"));
+ hkcu_pol_.reset(new ScopedRegistryKeyOverride(HKEY_CURRENT_USER,
+ L"hkcu_fake"));
}
void TearDown() {
hkcu_pol_.reset(NULL);
hklm_pol_.reset(NULL);
- TempRegKeyOverride::DeleteAllTempKeys();
+ ScopedRegistryKeyOverride::DeleteAllTempKeys();
}
// This is used to manage life cycle of PolicySettings singleton.
// base::ShadowingAtExitManager at_exit_manager_;
- scoped_ptr<TempRegKeyOverride> hklm_pol_;
- scoped_ptr<TempRegKeyOverride> hkcu_pol_;
+ scoped_ptr<ScopedRegistryKeyOverride> hklm_pol_;
+ scoped_ptr<ScopedRegistryKeyOverride> hkcu_pol_;
};
TEST_F(UtilTests, GetModuleVersionTest) {

Powered by Google App Engine
This is Rietveld 408576698