Remove webkit::ppapi::Resource.

ppapi/shared_impl/resource_tracker.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/resource_tracker.h"
 
 #include "ppapi/shared_impl/id_assignment.h"
 #include "ppapi/shared_impl/resource.h"
 
 namespace ppapi {
@@ skipping 124 matching lines @@
   return static_cast<int>(found->second->resources.size());
 }
 
 PP_Resource ResourceTracker::AddResource(Resource* object) {
   // If the plugin manages to create too many resources, don't do crazy stuff.
   if (last_resource_value_ == kMaxPPId)
     return 0;
 
   // If you hit this somebody forgot to call DidCreateInstance or the resource
   // was created with an invalid PP_Instance.
-  DCHECK(instance_map_.find(object->pp_instance()) != instance_map_.end());
+  //
+  // This is specifically a check even in release mode. When creating resources
+  // it can be easy to forget to validate the instance parameter. If somebody
+  // does forget, we don't want to introduce a vulnerability with invalid
+  // pointers floating around, so we die ASAP.
+  CHECK(instance_map_.find(object->pp_instance()) != instance_map_.end());

[viettrungluu, 2011/08/22 23:19:46]

Hrm, this could conceivably be a fairly hot method, so it'd probably be better
to keep the result of the .find() and then use it below, rather than doing two
searches.

 
   PP_Resource new_id = MakeTypedId(++last_resource_value_, PP_ID_TYPE_RESOURCE);
   instance_map_[object->pp_instance()]->resources.insert(new_id);
 
   live_resources_[new_id] = ResourceAndRefCount(object, 0);
   return new_id;
 }
 
 void ResourceTracker::RemoveResource(Resource* object) {
   PP_Resource pp_resource = object->pp_resource();
   if (object->pp_instance())
     instance_map_[object->pp_instance()]->resources.erase(pp_resource);
   live_resources_.erase(pp_resource);
 }
 
 }  // namespace ppapi