Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6173)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 7669052: Added DataTypeController integration and UI surfacing for syncing Search Engines. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: TODO comment in ProfileImpl Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.cc
===================================================================
--- chrome/browser/profiles/profile_impl.cc (revision 97853)
+++ chrome/browser/profiles/profile_impl.cc (working copy)
@@ -671,6 +671,11 @@
// Remove pref observers
pref_change_registrar_.RemoveAll();
+ // The sync service needs to be deleted before the services it calls.
+ // TODO(sync): Make ProfileSyncService into a PKS and let the PDM take care of
Sheridan Rawlins 2011/08/25 08:19:16 Shouldn't this be TODO(someone's ldap) ?
SteveT 2011/08/25 14:50:55 The issue was assigned to the Sync PM, tmccoy, for
+ // the cleanup below.
+ sync_service_.reset();
+
ProfileDependencyManager::GetInstance()->DestroyProfileServices(this);
if (db_tracker_) {
@@ -689,9 +694,6 @@
download_manager_ = NULL;
}
- // The sync service needs to be deleted before the services it calls.
- sync_service_.reset();
-
// Password store uses WebDB, shut it down before the WebDB has been shutdown.
if (password_store_.get())
password_store_->Shutdown();

Powered by Google App Engine
This is Rietveld 408576698