Issue 7669044: ntp4: update bubble position in another place

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7669044: ntp4: update bubble position in another place (Closed)

Created:
9 years, 4 months ago by Evan Stade

Modified:
9 years, 4 months ago

Reviewers:
csilv, commit-bot: I haz the power

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ntp4: update bubble position in another place BUG=93154 TEST=add a lot of apps pages, and then open a new ntp; the bubble should be in the right place. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97281

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/resources/ntp4/new_tab.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

csilv

LGTM I guess this hilights the fact that I really need to refactor those two ...

9 years, 4 months ago (2011-08-18 01:18:37 UTC) #2

Change committed as 97281