Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 7669018: Clean up the nesting stack in the full code generator. (Closed)

Created:
9 years, 4 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 4 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Clean up the nesting stack in the full code generator. Remove unused methods, introduce named constants, and attempt to add some sanity to naming. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -111 lines) Patch
M src/arm/full-codegen-arm.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen.h View 3 chunks +49 lines, -64 lines 0 comments Download
M src/full-codegen.cc View 15 chunks +24 lines, -27 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 4 months ago (2011-08-17 13:35:55 UTC) #1
William Hesse
9 years, 4 months ago (2011-08-17 13:55:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698