Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc

Issue 7669012: Broke BrowserAccessibilityTest.HitTestTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/accessibility/browser_accessibility_manager_unittest.cc
===================================================================
--- chrome/browser/accessibility/browser_accessibility_manager_unittest.cc (revision 97079)
+++ chrome/browser/accessibility/browser_accessibility_manager_unittest.cc (working copy)
@@ -604,7 +604,7 @@
tree2_1.role = WebAccessibility::ROLE_WEB_AREA;
WebAccessibility tree2_2;
- tree2_2.id = 1002;
+ tree2_2.id = 1001;
tree2_2.role = WebAccessibility::ROLE_BUTTON;
tree2_1.children.push_back(tree2_2);
@@ -614,15 +614,18 @@
// Fire another load complete.
manager->OnAccessibilityNotifications(params);
- BrowserAccessibility* acc2_2 = manager->GetFromRendererID(1002);
+ BrowserAccessibility* acc2_2 = manager->GetFromRendererID(1001);
// Verify the root has not changed.
EXPECT_EQ(root, manager->GetRoot());
- // And the new child exists.
+ // And the proper child remains.
EXPECT_EQ(WebAccessibility::ROLE_BUTTON, acc2_2->role());
- EXPECT_EQ(1002, acc2_2->renderer_id());
+ EXPECT_EQ(1001, acc2_2->renderer_id());
+ // Verify we don't reuse objects that have changed roles.
+ EXPECT_NE(acc1_2, acc2_2);
+
// Ensure we properly cleaned up.
manager.reset();
ASSERT_EQ(0, CountedBrowserAccessibility::global_obj_count_);
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698