webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc - Issue 7669002: Introduction of parameter to readBackFramebuffer set of APIs to allow reading from the currently ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

Issue 7669002: Introduction of parameter to readBackFramebuffer set of APIs to allow reading from the currently ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h ('k') | webkit/gpu/webgraphicscontext3d_in_process_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

===================================================================

--- webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (revision 96380)

+++ webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (working copy)

@@ -843,7 +843,7 @@

if (mustRestoreFBO) {

gl_->BindFramebuffer(GL_FRAMEBUFFER, framebuffer);

}

- gl_->ReadPixels(0, 0, width, height,

+ gl_->ReadPixels(0, 0, width, height,

GL_RGBA, GL_UNSIGNED_BYTE, pixels);

// Swizzle red and blue channels

@@ -867,8 +867,11 @@

bool WebGraphicsContext3DInProcessCommandBufferImpl::readBackFramebuffer(

unsigned char* pixels,

- size_t buffer_size) {

- return readBackFramebuffer(pixels, buffer_size, 0, width(), height());

+ size_t buffer_size, bool bindDefaultBackbuffer) {

+ if (bindDefaultBackbuffer)

+ return readBackFramebuffer(pixels, buffer_size, 0, width(), height());

+ return readBackFramebuffer(pixels, buffer_size, bound_fbo_, width(), height());

}

void WebGraphicsContext3DInProcessCommandBufferImpl::synthesizeGLError(