Improve memcheck_analyze

Improve memcheck_analyze
1) Skip the report&suppression frames starting from
    testing::internal::BlahExceptions and RunnableMethod
   as they usually have nothing to do with the error but significantly increase
   the size of the suppressions
2) Drop anonymous namespace prefixes
3) Unify boring callers between error reporting code and suppression generation

TEST=ran locally on base_unittests Sanity tests with sanity suppressions removed
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97116

[Timur Iskhodzhanov, 2011-08-16 13:48:02]

Hi Lei,

Can you please review this CL?

I think it'll make reports&suppressions more compact, a bit wider (but not too
much) and more readable.

I want you to pay some extra attention to the RunnableMethod  _BORING_CALLER as
this *may* cut too much frames from reports though I couldn't imagine a
real-life example of such problem. If you can - I'd be happy to remove the
"RunnableMethod" line until we agree on it.

Thanks,
Timur

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
File tools/valgrind/memcheck_analyze.py (left):

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
tools/valgrind/memcheck_analyze.py:33: "testing::Test::Run()",
this wasn't matching anything

[Lei Zhang, 2011-08-16 18:49:04]

LGTM

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
File tools/valgrind/memcheck_analyze.py (right):

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
tools/valgrind/memcheck_analyze.py:43: "_ZN14RunnableMethod.*",
Indeed, stuff below this is quite boring and can probably be safely omitted.

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
tools/valgrind/memcheck_analyze.py:297: for boring_caller in _BORING_CALLERS:
I think this double for-loop can exit a bit earlier if we write it as:

enough_frames = False
for frameno in range(len(supplines)):
  for boring_caller in _BORING_CALLERS:
    if re.search(boring_caller, supplines[frameno]):
      newlen = frameno
      enough_frames = True
      break
  if enough_frames:
    break

[Timur Iskhodzhanov, 2011-08-17 09:09:18]

Thank you for your review!

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
File tools/valgrind/memcheck_analyze.py (right):

http://codereview.chromium.org/7665001/diff/1001/tools/valgrind/memcheck_anal...
tools/valgrind/memcheck_analyze.py:297: for boring_caller in _BORING_CALLERS:
Absolutely!
I've started from this one (not the gatherFrames part) and for some reason my
mind had stuck on this sub-optimal solution.
In fact, "for frameno in range(newlen)" should be even better

On 2011/08/16 18:49:04, Lei Zhang wrote:
> I think this double for-loop can exit a bit earlier if we write it as:
> 
> enough_frames = False
> for frameno in range(len(supplines)):
>   for boring_caller in _BORING_CALLERS:
>     if re.search(boring_caller, supplines[frameno]):
>       newlen = frameno
>       enough_frames = True
>       break
>   if enough_frames:
>     break