Issue 7664019: Move download UMA functions to their own file in content. Also fire the chrome-only notification ...

Issue 7664019: Move download UMA functions to their own file in content. Also fire the chrome-only notification ... (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move download UMA functions to their own file in content. Also fire the chrome-only notification for download initiated in chrome code from the chrome delegate. BUG=82782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97059

Patch Set 1 : '' #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+273 lines, -253 lines)			Patch
M	chrome/browser/download/download_throttling_resource_handler.cc	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/download/download_util.h	View	2 chunks	+0 lines, -58 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	4 chunks	+0 lines, -152 lines	0 comments	Download
M	chrome/browser/download/drag_download_file.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/DEPS	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/browser/download/download_item.cc	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/download/download_resource_handler.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A	content/browser/download/download_stats.h	View	1 chunk	+77 lines, -0 lines	2 comments	Download
A	content/browser/download/download_stats.cc	View	1 chunk	+151 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with a comment http://codereview.chromium.org/7664019/diff/7001/content/browser/download/download_stats.h File content/browser/download/download_stats.h (right): http://codereview.chromium.org/7664019/diff/7001/content/browser/download/download_stats.h#newcode75 content/browser/download/download_stats.h:75: } // namespace download_util nit: ...

9 years, 4 months ago (2011-08-16 23:36:12 UTC) #2

jam

9 years, 4 months ago (2011-08-16 23:44:40 UTC) #3

http://codereview.chromium.org/7664019/diff/7001/content/browser/download/dow...
File content/browser/download/download_stats.h (right):

http://codereview.chromium.org/7664019/diff/7001/content/browser/download/dow...
content/browser/download/download_stats.h:75: }  // namespace download_util
On 2011/08/16 23:36:13, Paweł Hajdan Jr. wrote:
> nit: download_stats

Done.

Expand Messages | Collapse Messages