Issue 7664018: Remove string from BrowserProcess interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7664018: Remove string from BrowserProcess interface. (Closed)

Created:
9 years, 4 months ago by tony

Modified:
9 years, 4 months ago

Reviewers:
Bernhard Bauer, commit-bot: I haz the power

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove string from BrowserProcess interface. It's an interface and shouldn't have any member variables. Also, it's not used anymore. TEST=PluginDataRemoverTest browser tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97110

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove test #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	chrome/browser/browser_process.h	View		2 chunks	+0 lines, -11 lines	0 comments	Download
	M	chrome/browser/plugin_data_remover_browsertest.cc	View	1	3 chunks	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

The code was refactored in http://codereview.chromium.org/7230052 and this string no longer used. It looks like ...

9 years, 4 months ago (2011-08-16 19:50:04 UTC) #1

Bernhard Bauer

LGTM, thanks for the cleanup! http://codereview.chromium.org/7664018/diff/1/chrome/browser/plugin_data_remover_browsertest.cc File chrome/browser/plugin_data_remover_browsertest.cc (right): http://codereview.chromium.org/7664018/diff/1/chrome/browser/plugin_data_remover_browsertest.cc#newcode53 chrome/browser/plugin_data_remover_browsertest.cc:53: IN_PROC_BROWSER_TEST_F(PluginDataRemoverTest, AtShutdown) { This ...

9 years, 4 months ago (2011-08-16 20:25:59 UTC) #2

Change committed as 97110

Expand Messages | Collapse Messages