Issue 7664005: Move DownloadResourceHandler to content.

Issue 7664005: Move DownloadResourceHandler to content. (Closed)

Created:
9 years, 4 months ago by jam

Modified:
9 years, 4 months ago

Reviewers:
ahendrickson

CC:
chromium-reviews, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move DownloadResourceHandler to content. TBR=rdsmith BUG=82782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96871

Patch Set 1 : '' #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -373 lines)			Patch
D	chrome/browser/renderer_host/download_resource_handler.h	View	1 chunk	+0 lines, -100 lines	0 comments	Download
D	chrome/browser/renderer_host/download_resource_handler.cc	View	1 chunk	+0 lines, -265 lines	0 comments	Download
M	chrome/browser/renderer_host/download_throttling_resource_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	content/browser/download/download_resource_handler.h	View	2 chunks	+3 lines, -3 lines	1 comment	Download
A +	content/browser/download/download_resource_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

Andy, would you take a look at this? It's TBR (and already committed) because it's ...

9 years, 4 months ago (2011-08-19 15:02:52 UTC) #2

ahendrickson

LGTM, after one fix $-) http://codereview.chromium.org/7664005/diff/20/content/browser/download/download_resource_handler.h File content/browser/download/download_resource_handler.h (right): http://codereview.chromium.org/7664005/diff/20/content/browser/download/download_resource_handler.h#newcode5 content/browser/download/download_resource_handler.h:5: #ifndef CONTENT_BROWSER_RENDERER_HOST_DOWNLOAD_RESOURCE_HANDLER_H_ Should be ...

9 years, 4 months ago (2011-08-19 15:33:46 UTC) #3

jam

9 years, 4 months ago (2011-08-19 15:50:15 UTC) #4

On Fri, Aug 19, 2011 at 8:33 AM, <ahendrickson@chromium.org> wrote:

> LGTM, after one fix $-)
>
>
> http://codereview.chromium.**org/7664005/diff/20/content/**
>
browser/download/download_**resource_handler.h<http://codereview.chromium.org/7664005/diff/20/content/browser/download/download_resource_handler.h>
> File content/browser/download/**download_resource_handler.h (right):
>
> http://codereview.chromium.**org/7664005/diff/20/content/**
>
browser/download/download_**resource_handler.h#newcode5<http://codereview.chromium.org/7664005/diff/20/content/browser/download/download_resource_handler.h#newcode5>
> content/browser/download/**download_resource_handler.h:5: #ifndef
> CONTENT_BROWSER_RENDERER_HOST_**DOWNLOAD_RESOURCE_HANDLER_H_
> Should be
>
> CONTENT_BROWSER_DOWNLOAD_**DOWNLOAD_RESOURCE_HANDLER_H_


thanks, will do in a followup

>
>
>
http://codereview.chromium.**org/7664005/<http://codereview.chromium.org/7664...
>

Expand Messages | Collapse Messages