Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 7663015: Fix ChromeFrame net tests hang on the windows try bots (Closed)

Created:
9 years, 4 months ago by ananta
Modified:
9 years, 4 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, amit, darin-cc_chromium.org, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Ensure that webkit ASSERTION's don't fire during CRT cleanup in debug runs of the chrome frame net tests suite by terminating the exe using ExitProcess in debug builds. These cause the exe to crash during exit, thus turning the windows try bot runs red. BUG=none TEST=chrome frame net tests should run to completion without crashing in debug runs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97041

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
9 years, 4 months ago (2011-08-16 21:59:13 UTC) #1
M-A Ruel
lgtm with nit. It would have been nice to not have the assert fire in ...
9 years, 4 months ago (2011-08-16 22:03:47 UTC) #2
ananta
On 2011/08/16 22:03:47, Marc-Antoine Ruel wrote: > lgtm with nit. It would have been nice ...
9 years, 4 months ago (2011-08-16 22:10:52 UTC) #3
ananta
9 years, 4 months ago (2011-08-16 22:10:59 UTC) #4
http://codereview.chromium.org/7663015/diff/5001/chrome_frame/test/net/fake_e...
File chrome_frame/test/net/fake_external_tab.cc (right):

http://codereview.chromium.org/7663015/diff/5001/chrome_frame/test/net/fake_e...
chrome_frame/test/net/fake_external_tab.cc:584: #ifdef _DEBUG
On 2011/08/16 22:03:47, Marc-Antoine Ruel wrote:
> In general we use #if !defined(NDEBUG) since _DEBUG is a MS-extension. Even if
> this is a windows-only test, I'd rather not encourage that.

Done.

Powered by Google App Engine
This is Rietveld 408576698