Issue 7663008: Add GetInputMethodDescriptorFromXkbId function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7663008: Add GetInputMethodDescriptorFromXkbId function. (Closed)

Created:
9 years, 4 months ago by Yusuke Sato

Modified:
9 years, 4 months ago

Reviewers:
mazda

CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add GetInputMethodDescriptorFromXkbId function. I'll use the new function to implement a UI for virtual keyboard management. BUG=None TEST=ran unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97084

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	chrome/browser/chromeos/input_method/input_method_util.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View		5 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mazda

LGTM with a nit http://codereview.chromium.org/7663008/diff/1/chrome/browser/chromeos/input_method/input_method_util.h File chrome/browser/chromeos/input_method/input_method_util.h (right): http://codereview.chromium.org/7663008/diff/1/chrome/browser/chromeos/input_method/input_method_util.h#newcode97 chrome/browser/chromeos/input_method/input_method_util.h:97: // Converts a XKB layout ...

9 years, 4 months ago (2011-08-17 02:13:26 UTC) #2

Yusuke Sato

9 years, 4 months ago (2011-08-17 02:30:21 UTC) #3

http://codereview.chromium.org/7663008/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/7663008/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/input_method_util.h:97: // Converts a XKB
layout ID to an input method descriptor. Returns NULL when
On 2011/08/17 02:13:27, mazda wrote:
> nit: an XKB

Done.

Expand Messages | Collapse Messages