Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 7663005: Make scanner not accept invalid unicode escapes in identifiers. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 4 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Make scanner not accept invalid unicode escapes in identifiers. BUG=v8:1620 TEST=mjsunit/regress/regress-1620 Committed: http://code.google.com/p/v8/source/detail?r=8942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M src/scanner-base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scanner-base.cc View 4 chunks +16 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-1620.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 4 months ago (2011-08-16 07:58:02 UTC) #1
Erik Corry
9 years, 4 months ago (2011-08-16 10:25:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698