Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7663001: Make bubble_border use resources under ui/resources. (Closed)

Created:
9 years, 4 months ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 4 months ago
CC:
chromium-reviews, pam+watch_chromium.org, alicet1
Visibility:
Public.

Description

Make bubble_border use resources under ui/resources. This issue was originally http://codereview.chromium.org/7584007/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97054

Patch Set 1 #

Patch Set 2 : Merged #

Patch Set 3 : Applied changes from alicet #

Patch Set 4 : Updated paths to rc files #

Patch Set 5 : Added more paths. #

Patch Set 6 : Merge #

Patch Set 7 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -26 lines) Patch
D chrome/app/theme/bubble_b.png View Binary file 0 comments Download
D chrome/app/theme/bubble_bl.png View Binary file 0 comments Download
D chrome/app/theme/bubble_br.png View Binary file 0 comments Download
D chrome/app/theme/bubble_l.png View Binary file 0 comments Download
D chrome/app/theme/bubble_pointer_b.png View Binary file 0 comments Download
D chrome/app/theme/bubble_pointer_l.png View Binary file 0 comments Download
D chrome/app/theme/bubble_pointer_r.png View Binary file 0 comments Download
D chrome/app/theme/bubble_pointer_t.png View Binary file 0 comments Download
D chrome/app/theme/bubble_r.png View Binary file 0 comments Download
D chrome/app/theme/bubble_t.png View Binary file 0 comments Download
D chrome/app/theme/bubble_tl.png View Binary file 0 comments Download
D chrome/app/theme/bubble_tr.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources_large.grd View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble_border.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 10 chunks +10 lines, -0 lines 0 comments Download
M tools/grit/resource_ids View 1 chunk +7 lines, -0 lines 0 comments Download
D ui/resources/bubble_close.png View Binary file 0 comments Download
A ui/resources/ui_resources_large.grd View 1 chunk +31 lines, -0 lines 0 comments Download
A ui/resources/ui_resources_standard.grd View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/ui_resources.gypi View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Ben, This was originally landed as http://codereview.chromium.org/7584007/ However, something is still not right on ...
9 years, 4 months ago (2011-08-16 18:54:13 UTC) #1
Emmanuel Saint-loubert-Bié
Hi Ben, As per my tests on my local Windows machine Alice has figured out ...
9 years, 4 months ago (2011-08-16 19:54:44 UTC) #2
Ben Goodger (Google)
9 years, 4 months ago (2011-08-16 19:56:48 UTC) #3 
On 2011/08/16 19:54:44, Emmanuel Saint-loubert wrote:
> Hi Ben,
> 
> As per my tests on my local Windows machine Alice has figured out the issue
with
> the browser_dll.gypi. Can you please approve?
> 
> Thanks,
> 
> -- Emmanuel

LGTM

Powered by Google App Engine
This is Rietveld 408576698