Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 7662001: ntp4: remove apps promo 'no, thanks' link. (Closed)

Created:
9 years, 4 months ago by Evan Stade
Modified:
9 years, 4 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp4: remove apps promo 'no, thanks' link. Link is no longer necessary as discussed in email thread. Users can just switch away from the page or install an app to make the promo go away. BUG=92524 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97171

Patch Set 1 #

Total comments: 1

Patch Set 2 : rbyers review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M chrome/browser/resources/ntp4/apps_page.css View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.js View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
this is a temporary solution. We may make more changes to the way the promo/explanatory ...
9 years, 4 months ago (2011-08-16 01:43:33 UTC) #1
Rick Byers
LGTM with a minor suggestion (clean up html as well since you're otherwise purging this ...
9 years, 4 months ago (2011-08-16 13:32:30 UTC) #2
Evan Stade
done and done
9 years, 4 months ago (2011-08-16 18:27:58 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-16 18:30:34 UTC) #4
Can't apply patch for file chrome/browser/ui/webui/ntp/app_launcher_handler.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/webui/ntp/app_launcher_handler.cc
Hunk #1 FAILED at 592.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/webui/ntp/app_launcher_handler.cc.rej

Powered by Google App Engine
This is Rietveld 408576698