Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/automation/automation_provider.h

Issue 7661031: Tag IPC::Channel::Listener implementations with OVERRIDE (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/automation/automation_resource_message_filter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This implements a browser-side endpoint for UI automation activity. 5 // This implements a browser-side endpoint for UI automation activity.
6 // The client-side endpoint is implemented by AutomationProxy. 6 // The client-side endpoint is implemented by AutomationProxy.
7 // The entire lifetime of this object should be contained within that of 7 // The entire lifetime of this object should be contained within that of
8 // the BrowserProcess, and in particular the NotificationService that's 8 // the BrowserProcess, and in particular the NotificationService that's
9 // hung off of it. 9 // hung off of it.
10 10
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 // Add or remove a non-owning reference to a tab's LoginHandler. This is for 121 // Add or remove a non-owning reference to a tab's LoginHandler. This is for
122 // when a login prompt is shown for HTTP/FTP authentication. 122 // when a login prompt is shown for HTTP/FTP authentication.
123 // TODO(mpcomplete): The login handling is a fairly special purpose feature. 123 // TODO(mpcomplete): The login handling is a fairly special purpose feature.
124 // Eventually we'll probably want ways to interact with the ChromeView of the 124 // Eventually we'll probably want ways to interact with the ChromeView of the
125 // login window in a generic manner, such that it can be used for anything, 125 // login window in a generic manner, such that it can be used for anything,
126 // not just logins. 126 // not just logins.
127 void AddLoginHandler(NavigationController* tab, LoginHandler* handler); 127 void AddLoginHandler(NavigationController* tab, LoginHandler* handler);
128 void RemoveLoginHandler(NavigationController* tab); 128 void RemoveLoginHandler(NavigationController* tab);
129 129
130 // IPC implementations 130 // IPC::Channel::Listener implementation.
131 virtual bool Send(IPC::Message* msg); 131 virtual bool Send(IPC::Message* msg) OVERRIDE;
132 virtual void OnChannelConnected(int pid); 132 virtual void OnChannelConnected(int pid) OVERRIDE;
133 virtual bool OnMessageReceived(const IPC::Message& msg); 133 virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
134 virtual void OnChannelError(); 134 virtual void OnChannelError() OVERRIDE;
135 135
136 IPC::Message* reply_message_release() { 136 IPC::Message* reply_message_release() {
137 IPC::Message* reply_message = reply_message_; 137 IPC::Message* reply_message = reply_message_;
138 reply_message_ = NULL; 138 reply_message_ = NULL;
139 return reply_message; 139 return reply_message;
140 } 140 }
141 141
142 // Adds the extension passed in to the extension tracker, and returns 142 // Adds the extension passed in to the extension tracker, and returns
143 // the associated handle. If the tracker already contains the extension, 143 // the associated handle. If the tracker already contains the extension,
144 // the handle is simply returned. 144 // the handle is simply returned.
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 // True iff the Chrome OS network library finished initialization. 384 // True iff the Chrome OS network library finished initialization.
385 bool network_library_initialized_; 385 bool network_library_initialized_;
386 386
387 // ID of automation channel. 387 // ID of automation channel.
388 std::string channel_id_; 388 std::string channel_id_;
389 389
390 DISALLOW_COPY_AND_ASSIGN(AutomationProvider); 390 DISALLOW_COPY_AND_ASSIGN(AutomationProvider);
391 }; 391 };
392 392
393 #endif // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_ 393 #endif // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/automation/automation_resource_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698