content/renderer/media/webrtc_audio_device_impl.cc - Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_impl.cc

Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Minor changes based on review by Andrew Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc_audio_device_impl.cc

===================================================================

--- content/renderer/media/webrtc_audio_device_impl.cc (revision 98001)

+++ content/renderer/media/webrtc_audio_device_impl.cc (working copy)

@@ -389,8 +389,9 @@

LOG(WARNING) << "Recording is already active";

return 0;

}

- recording_ = audio_input_device_->Start();

- return (recording_ ? 0 : -1);

+ audio_input_device_->Start();

+ recording_ = true;

+ return 0;

}

int32_t WebRtcAudioDeviceImpl::StopRecording() {

« no previous file with comments | « content/renderer/media/audio_input_message_filter.cc ('k') | no next file » | no next file with comments »