content/renderer/media/audio_input_message_filter.cc - Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_input_message_filter.cc

Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Removed Stop call in destructor. Added DCHECK instead. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_input_device.cc ('K') | « content/renderer/media/audio_input_device.cc ('k') | content/renderer/media/webrtc_audio_device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_input_message_filter.cc

===================================================================

--- content/renderer/media/audio_input_message_filter.cc (revision 97438)

+++ content/renderer/media/audio_input_message_filter.cc (working copy)

@@ -71,15 +71,17 @@

base::FileDescriptor socket_descriptor,

#endif

uint32 length) {

+#if !defined(OS_WIN)

+ base::SyncSocket::Handle socket_handle = socket_descriptor.fd;

+#endif

Delegate* delegate = delegates_.Lookup(stream_id);

if (!delegate) {

DLOG(WARNING) << "Got audio stream event for a non-existent or removed"

" audio capturer.";

+ base::SharedMemory::CloseHandle(handle);

+ base::SyncSocket socket(socket_handle);

return;

}

-#if !defined(OS_WIN)

- base::SyncSocket::Handle socket_handle = socket_descriptor.fd;

-#endif

// Forward message to the stream delegate.

delegate->OnLowLatencyCreated(handle, socket_handle, length);

}