content/renderer/media/audio_input_device.h - Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_input_device.h

Issue 7661017: Refactor AudioInputDevice to remove race conditions and allow more flexible calling sequences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/audio_input_device.h

===================================================================

--- content/renderer/media/audio_input_device.h (revision 96746)

+++ content/renderer/media/audio_input_device.h (working copy)

@@ -80,8 +80,8 @@

CaptureCallback* callback);

virtual ~AudioInputDevice();

- // Starts audio capturing. Returns |true| on success.

- bool Start();

+ // Starts audio capturing.

+ void Start();

// Stops audio capturing. Returns |true| on success.

bool Stop();

@@ -111,7 +111,7 @@

// sends IPC messages on that thread.

void InitializeOnIOThread(const AudioParameters& params);

void StartOnIOThread();

- void ShutDownOnIOThread();

+ void ShutDownOnIOThread(base::WaitableEvent* completion);

void SetVolumeOnIOThread(double volume);

void Send(IPC::Message* message);

« no previous file with comments | « no previous file | content/renderer/media/audio_input_device.cc » ('j') | content/renderer/media/audio_input_device.cc » ('J')