base: Add Is* functions to Value class.

remoting/host/plugin/policy_hack/nat_policy_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Most of this code is copied from various classes in
 // src/chrome/browser/policy. In particular, look at
 //
 //   file_based_policy_loader.{h,cc}
 //   config_dir_policy_provider.{h,cc}
 //
@@ skipping 163 matching lines @@
       JSONFileValueSerializer deserializer(*config_file_iter);
       int error_code = 0;
       std::string error_msg;
       scoped_ptr<Value> value(
           deserializer.Deserialize(&error_code, &error_msg));
       if (!value.get()) {
         LOG(WARNING) << "Failed to read configuration file "
                      << config_file_iter->value() << ": " << error_msg;
         continue;
       }
-      if (!value->IsType(Value::TYPE_DICTIONARY)) {
+      if (!value->IsDictionary()) {
         LOG(WARNING) << "Expected JSON dictionary in configuration file "
                      << config_file_iter->value();
         continue;
       }
       policy->MergeDictionary(static_cast<DictionaryValue*>(value.get()));
     }
 
     return policy;
   }
 
   void Reload() {
     DCHECK(OnPolicyThread());
     // Check the directory time in order to see whether a reload is required.
     base::TimeDelta delay;
     base::Time now = base::Time::Now();
     if (!IsSafeToReloadPolicy(now, &delay)) {
       ScheduleReloadTask(delay);
       return;
     }
 
     // Check again in case the directory has changed while reading it.
     if (!IsSafeToReloadPolicy(now, &delay)) {
       ScheduleReloadTask(delay);
       return;
     }
 
     // Load the policy definitions.
-    scoped_ptr<DictionaryValue> new_policy(Load());
+    scoped_ptr<base::DictionaryValue> new_policy(Load());

[tony, 2011/08/19 17:24:21]

Why is this necessary here?  There are lots of other references to
DictionaryValue that you didn't change. I would leave this unchanged for now.

[tfarina, 2011/08/19 18:40:47]

Done.

     UpdateNatPolicy(new_policy.get());
 
     ScheduleFallbackReloadTask();
   }
 
   bool IsSafeToReloadPolicy(const base::Time& now, base::TimeDelta* delay) {
     DCHECK(OnPolicyThread());
     DCHECK(delay);
     const base::TimeDelta kSettleInterval =
         base::TimeDelta::FromSeconds(kSettleIntervalSeconds);
@@ skipping 43 matching lines @@
   base::WeakPtrFactory<NatPolicyLinux> weak_factory_;
 };
 
 NatPolicy* NatPolicy::Create(base::MessageLoopProxy* message_loop_proxy) {
   FilePath policy_dir(kPolicyDir);
   return new NatPolicyLinux(message_loop_proxy, policy_dir);
 }
 
 }  // namespace policy_hack
 }  // namespace remoting