base: Add Is* functions to Value class.

chrome/test/webdriver/commands/command.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/commands/command.h"
 
 namespace webdriver {
 
 Command::Command(const std::vector<std::string>& path_segments,
                  const DictionaryValue* const parameters)
@@ skipping 23 matching lines @@
 }
 
 bool Command::HasParameter(const std::string& key) const {
   return parameters_.get() && parameters_->HasKey(key);
 }
 
 bool Command::IsNullParameter(const std::string& key) const {
   Value* value;
   return parameters_.get() &&
          parameters_->Get(key, &value) &&
-         value->IsType(Value::TYPE_NULL);
+         value->IsNull();

[tony, 2011/08/19 17:24:21]

Nit: Maybe we can fit this on 2 lines?  Also, the indenting is the wrong amount
(should only be 4 spaces in from the previous line, so 6 spaces total).

[tfarina, 2011/08/19 18:40:47]

Done.

 }
 
 bool Command::GetStringParameter(const std::string& key,
                                  string16* out) const {
   return parameters_.get() != NULL && parameters_->GetString(key, out);
 }
 
 bool Command::GetStringParameter(const std::string& key,
                                  std::string* out) const {
   return parameters_.get() != NULL && parameters_->GetString(key, out);
@@ skipping 22 matching lines @@
                                      DictionaryValue** out) const {
   return parameters_.get() != NULL && parameters_->GetDictionary(key, out);
 }
 
 bool Command::GetListParameter(const std::string& key,
                                ListValue** out) const {
   return parameters_.get() != NULL && parameters_->GetList(key, out);
 }
 
 }  // namespace webdriver