Don't load third-party code

Don't load third-party code from any of the following locations:

Prefixes:
~/Library
/Library
/Network/Library

Suffixes:
Application Support/SIMBL/Plugins
Contextual Menu Items
Input Managers
ScriptingAdditions

Hosting parasitic third-party code in our application is the cause of
instability which has only increased since the release of Mac OS X 10.7
("Lion").

BUG=90193, 90920, 90716
TEST=Crash less? Watch the stats.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96893

[Nico, 2011-08-16 02:09:01]

do this on lion only?

On 2011/08/16 02:00:57, Mark Mentovai wrote:

[Mark Mentovai, 2011-08-16 02:46:29]

Why? Is third-party code expecting us to host it any more legitimate pre-Lion
than on Lion?

Put another way: I expect this might clean up some stability problems pre-Lion
that never bubbled up enough to cause us to investigate.

[Nico, 2011-08-16 03:13:54]

On Mon, Aug 15, 2011 at 7:46 PM,  <mark@chromium.org> wrote:
> Why?

This will break functionality for some people on 10.6. Since we
autoupdate, removing functionality needs to be done carefully. And on
10.6, these plugins had plenty of testing.

> Is third-party code expecting us to host it any more legitimate
> pre-Lion
> than on Lion?
>
> Put another way: I expect this might clean up some stability problems
> pre-Lion
> that never bubbled up enough to cause us to investigate.
>
> http://codereview.chromium.org/7661007/
>

[Mark Mentovai, 2011-08-16 04:01:52]

I’m not so sure. In a world where so many things are moving to 64 bits, and
input managers and contextual menu plugins already aren’t available, I’d be
surprised if people just expected this stuff to work 100% of the time.

Is there a specific plug-in or something that you’re concerned about?

I’d like to do this the aggressive way for at least one dev channel build, watch
the crashes, and then if we need to depending on feedback, pull back if needed.
The pullback might be limiting the disabler to certain OS versions, or it might
be whitelisting things known to be OK, or even going back to a blacklist of
things known not to be OK.

[Nico, 2011-08-16 04:04:05]

On Mon, Aug 15, 2011 at 9:01 PM,  <mark@chromium.org> wrote:
> I’m not so sure. In a world where so many things are moving to 64 bits, and
> input managers and contextual menu plugins already aren’t available, I’d be
> surprised if people just expected this stuff to work 100% of the time.
>
> Is there a specific plug-in or something that you’re concerned about?
>
> I’d like to do this the aggressive way for at least one dev channel build,
> watch
> the crashes, and then if we need to depending on feedback, pull back if
> needed.
> The pullback might be limiting the disabler to certain OS versions, or it
> might
> be whitelisting things known to be OK, or even going back to a blacklist of
> things known not to be OK.

I had nothing in particular in mind, no. Pushing to dev channel and
looking if anyone complains sounds fine.

[Nico, 2011-08-16 04:07:36]

Since I'm drive-by-ing, I might as well do a real review. Code LGTM.

[Mark Mentovai, 2011-08-16 04:22:16]

Might as well check it in now. Maybe it’ll make this dev build.