Issue 7661006: Disk cache: Detect hardware failures when reading the headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7661006: Disk cache: Detect hardware failures when reading the headers (Closed)

Created:
9 years, 4 months ago by rvargas (doing something else)

Modified:
9 years, 4 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Detect hardware failures when reading the headers of block mapped files. BUG=90087 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96971

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	net/disk_cache/mapped_file_win.cc	View		3 chunks	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gavinp

9 years, 4 months ago (2011-08-16 17:00:45 UTC) #2

LGTM, ignore or respect my nit as you will. :)

http://codereview.chromium.org/7661006/diff/1/net/disk_cache/mapped_file_win.cc
File net/disk_cache/mapped_file_win.cc (right):

http://codereview.chromium.org/7661006/diff/1/net/disk_cache/mapped_file_win....
net/disk_cache/mapped_file_win.cc:34: return NULL;
Minor Nit: Although this is almost at the end of the scope, I'd be ε happier if
the scoped_array<char> had been in a scope that ended right after this if.

Expand Messages | Collapse Messages