Issue 7661005: Cleanup:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7661005: Cleanup: (Closed)

Created:
9 years, 4 months ago by Peter Kasting

Modified:
9 years, 4 months ago

Reviewers:
dominich

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: * Remove using directives * Make more functions file-scope instead of private + static * Make .cc and .h order match BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96973

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+354 lines, -384 lines)			Patch
	M	chrome/browser/autocomplete/history_url_provider.h	View	1	3 chunks	+0 lines, -47 lines	0 comments	Download
	M	chrome/browser/autocomplete/history_url_provider.cc	View		19 chunks	+354 lines, -337 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dominich

9 years, 4 months ago (2011-08-16 14:06:32 UTC) #2

LGTM and thank you for taking the time to run cleanup passes.

You might have to merge with the new CalculateConfidence method if that gets
through the commit-bot soon.

Expand Messages | Collapse Messages