Issue 7661003: [ChromeOS] Show a loading UI before Gaia is loaded for WebUI login.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7661003: [ChromeOS] Show a loading UI before Gaia is loaded for WebUI login. (Closed)

Created:
9 years, 4 months ago by xiyuan

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, zel

CC:
chromium-reviews, arv (Not doing code reviews), achuithb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[ChromeOS] Show a loading UI before Gaia is loaded for WebUI login. - Show a loading throbber on loading gaia auth ext; - Gaia auth ext fires 'onLoginUILoaded' once Gaia is loaded and sent 'clearOldAttempts'; - Hide loading throober and show Gaia frame when 'onLoginUILoaded' is received; BUG=chromium-os:18765 TEST=Verify fix for chromium-os:18765. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97077

Patch Set 1 #

Patch Set 2 : onLoginUILoaded->loginUILoaded, default to hide gaia frame #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -11 lines)			Patch
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.html	View	1	1 chunk	+13 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_gaia_signin.js	View	1	3 chunks	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_signin.css	View		2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 97077

Expand Messages | Collapse Messages