src/isolate.cc - Issue 7660016: Fix memory leaks in ~Zone and ~Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 7660016: Fix memory leaks in ~Zone and ~Isolate (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 9ca61177ba7b41914987dbf0aaba503b50ab2773..cf693e088ae43621db8de9c0097c5ebd349419a2 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1591,6 +1591,11 @@ Isolate::~Isolate() {

delete global_handles_;

global_handles_ = NULL;

+ if (external_reference_table_ != NULL) {

Vitaly Repeshko 2011/08/16 17:52:32 It's safe to delete NULL. "if" is not necessary.

Jakob Kummerow 2011/08/17 08:47:30 Done.

+ delete external_reference_table_;

+ external_reference_table_ = NULL;

+ }

#ifdef ENABLE_DEBUGGER_SUPPORT

delete debugger_;

debugger_ = NULL;

« no previous file with comments | « no previous file | src/serialize.h » ('j') | src/zone.h » ('J')