Factor out dependncy on download throttling from core download code.

Factor out dependncy on download throttling from core download code.

BUG=82782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96991

[jam, 2011-08-16 16:59:53]

switching reviewers to Pawel since it looks like he's the only one in the office
with owners for downloads

[Paweł Hajdan Jr., 2011-08-16 17:14:08]

Please note that I'm not really familiar with most parts of the renderer host;
it may be a good idea to get a second reviewer for those parts.

http://codereview.chromium.org/7660007/diff/4007/chrome/browser/download/down...
File chrome/browser/download/download_request_limiter_observer.h (right):

http://codereview.chromium.org/7660007/diff/4007/chrome/browser/download/down...
chrome/browser/download/download_request_limiter_observer.h:13: class
DownloadRequestLimiterObserver : public TabContentsObserver {
Why don't you just make DownloadRequestLimiter a TabContentsObserver?

http://codereview.chromium.org/7660007/diff/4007/content/browser/renderer_hos...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/7660007/diff/4007/content/browser/renderer_hos...
content/browser/renderer_host/buffered_resource_handler.cc:311:
scoped_refptr<ResourceHandler> handler(
This is a bit suspicious to me: previously this wasn't scoped_refptr, so we
might be destroying the object too early now. But I don't really know this code.

[jam, 2011-08-16 18:18:20]

http://codereview.chromium.org/7660007/diff/4007/chrome/browser/download/down...
File chrome/browser/download/download_request_limiter_observer.h (right):

http://codereview.chromium.org/7660007/diff/4007/chrome/browser/download/down...
chrome/browser/download/download_request_limiter_observer.h:13: class
DownloadRequestLimiterObserver : public TabContentsObserver {
On 2011/08/16 17:14:08, Paweł Hajdan Jr. wrote:
> Why don't you just make DownloadRequestLimiter a TabContentsObserver?

An object can only watch one tab at a time.

http://codereview.chromium.org/7660007/diff/4007/content/browser/renderer_hos...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/7660007/diff/4007/content/browser/renderer_hos...
content/browser/renderer_host/buffered_resource_handler.cc:311:
scoped_refptr<ResourceHandler> handler(
On 2011/08/16 17:14:08, Paweł Hajdan Jr. wrote:
> This is a bit suspicious to me: previously this wasn't scoped_refptr, so we
> might be destroying the object too early now. But I don't really know this
code.

this is fine as well, we use this pattern in other places

[Paweł Hajdan Jr., 2011-08-16 18:19:22]

Rubber stamp LGTM