Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7659006: Remove libvpx from FFmpeg in favour of ffvp8. (Closed)

Created:
9 years, 4 months ago by scherkus (not reviewing)
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove libvpx from FFmpeg in favour of ffvp8. Clients in Chromium code can now link directly to libvpx without depending on FFmpeg / InitializeMediaLibrary(). BUG=50811 TEST=remoting_unittests, media_unittests, layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97071

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -363 lines) Patch
ffmpeg/binaries/win/avcodec-53.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
ffmpeg/binaries/win/avformat-53.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
ffmpeg/binaries/win/avutil-51.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M ffmpeg/build_ffmpeg.sh View 1 8 chunks +31 lines, -33 lines 0 comments Download
M ffmpeg/copy_config.sh View 1 1 chunk +28 lines, -33 lines 0 comments Download
D ffmpeg/source/avcodec-53.novpx_sigs View 1 chunk +0 lines, -31 lines 0 comments Download
M ffmpeg/source/avcodec-53.sigs View 2 chunks +1 line, -20 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/arm-neon/config.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/arm/config.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/ia32/config.h View 7 chunks +7 lines, -7 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/ia32/config.asm View 3 chunks +2 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/x64/config.h View 7 chunks +7 lines, -7 lines 0 comments Download
M ffmpeg/source/config/Chrome/linux/x64/config.asm View 3 chunks +2 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chrome/mac/ia32/config.h View 7 chunks +7 lines, -7 lines 0 comments Download
M ffmpeg/source/config/Chrome/mac/ia32/config.asm View 3 chunks +2 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chrome/win/ia32/config.h View 7 chunks +7 lines, -7 lines 0 comments Download
M ffmpeg/source/config/Chrome/win/ia32/config.asm View 3 chunks +2 lines, -4 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/arm-neon/config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/arm/config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/ia32/config.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/ia32/config.asm View 3 chunks +0 lines, -4 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/x64/config.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ffmpeg/source/config/ChromeOS/linux/x64/config.asm View 3 chunks +0 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/arm-neon/config.h View 6 chunks +6 lines, -6 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/arm/config.h View 6 chunks +6 lines, -6 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/ia32/config.h View 8 chunks +9 lines, -9 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/ia32/config.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/x64/config.h View 8 chunks +9 lines, -9 lines 0 comments Download
M ffmpeg/source/config/Chromium/linux/x64/config.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chromium/mac/ia32/config.h View 8 chunks +9 lines, -9 lines 0 comments Download
M ffmpeg/source/config/Chromium/mac/ia32/config.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/Chromium/win/ia32/config.h View 8 chunks +9 lines, -9 lines 0 comments Download
M ffmpeg/source/config/Chromium/win/ia32/config.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/arm-neon/config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/arm/config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/ia32/config.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/ia32/config.asm View 3 chunks +0 lines, -4 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/x64/config.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ffmpeg/source/config/ChromiumOS/linux/x64/config.asm View 3 chunks +0 lines, -4 lines 0 comments Download
M ffmpeg/source/ffmpeg.gyp View 5 chunks +6 lines, -36 lines 0 comments Download
M ffmpeg/source/ffmpeg_generated.gypi View 13 chunks +15 lines, -50 lines 0 comments Download
M ffmpeg/source/ffmpeg_stub_headers.fragment View 1 chunk +0 lines, -3 lines 0 comments Download
M libvpx/libvpx.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scherkus (not reviewing)
hclam: review everything :) fischman: I removed a few of your TODOs and I feel ...
9 years, 4 months ago (2011-08-16 04:43:59 UTC) #1
Ami GONE FROM CHROMIUM
Hawt! http://codereview.chromium.org/7659006/diff/1/ffmpeg/build_ffmpeg.sh File ffmpeg/build_ffmpeg.sh (right): http://codereview.chromium.org/7659006/diff/1/ffmpeg/build_ffmpeg.sh#newcode15 ffmpeg/build_ffmpeg.sh:15: if [ "$3" = "" ]; then -o ...
9 years, 4 months ago (2011-08-16 05:27:13 UTC) #2
ilja
I see nothing obviously wrong. And the .gypi changes look like magic to me.
9 years, 4 months ago (2011-08-16 05:31:21 UTC) #3
Alpha Left Google
http://codereview.chromium.org/7659006/diff/1/libvpx/libvpx.gyp File libvpx/libvpx.gyp (right): http://codereview.chromium.org/7659006/diff/1/libvpx/libvpx.gyp#newcode462 libvpx/libvpx.gyp:462: 'target_name': 'libvpx_include', On 2011/08/16 05:27:13, Ami Fischman wrote: > ...
9 years, 4 months ago (2011-08-16 10:24:39 UTC) #4
Alpha Left Google
LGTM.
9 years, 4 months ago (2011-08-16 10:25:30 UTC) #5
Ami GONE FROM CHROMIUM
scherkus: are you planning to fix webrtc as a follow-up change? http://www.google.com/codesearch#xSWYf0NTG_Q/trunk/src/modules/video_coding/codecs/vp8/main/source/vp8.gyp&q=libvpx%20package:http://webrtc%5C.googlecode%5C.com&type=cs&l=34 seems like it's ...
9 years, 4 months ago (2011-08-16 15:52:45 UTC) #6
hclam
I have a pending CL for fixing that vp8.gyp in webrtc. 2011年8月16日16:52 Ami Fischman <fischman@chromium.org>: ...
9 years, 4 months ago (2011-08-16 15:53:35 UTC) #7
Ami GONE FROM CHROMIUM
> > I have a pending CL for fixing that vp8.gyp in webrtc. > Great!
9 years, 4 months ago (2011-08-16 15:55:31 UTC) #8
scherkus (not reviewing)
http://codereview.chromium.org/7659006/diff/1/ffmpeg/build_ffmpeg.sh File ffmpeg/build_ffmpeg.sh (right): http://codereview.chromium.org/7659006/diff/1/ffmpeg/build_ffmpeg.sh#newcode15 ffmpeg/build_ffmpeg.sh:15: if [ "$3" = "" ]; then On 2011/08/16 ...
9 years, 4 months ago (2011-08-17 00:42:01 UTC) #9
Ami GONE FROM CHROMIUM
9 years, 4 months ago (2011-08-17 00:49:31 UTC) #10 
LGTM

Powered by Google App Engine
This is Rietveld 408576698