Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 7658020: Add link to RFC2361 for WAV codecs as I always have a hard time finding said spec. (Closed)

Created:
9 years, 4 months ago by scherkus (not reviewing)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add link to RFC2361 for WAV codecs as I always have a hard time finding said spec. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97061

Patch Set 1 #

Total comments: 2

Patch Set 2 : no comman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M net/base/mime_util.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
LGTM http://codereview.chromium.org/7658020/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): http://codereview.chromium.org/7658020/diff/1/net/base/mime_util.cc#newcode263 net/base/mime_util.cc:263: // http://tools.ietf.org/html/rfc2361 http://tools.ietf.org/html/rfc2361#appendix-A ? http://codereview.chromium.org/7658020/diff/1/net/base/mime_util.cc#newcode274 net/base/mime_util.cc:274: "1", // ...
9 years, 4 months ago (2011-08-16 20:01:11 UTC) #1
commit-bot: I haz the power
Presubmit check for 7658020-2002 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-16 20:02:00 UTC) #2
scherkus (not reviewing)
+willchan for OWNERS
9 years, 4 months ago (2011-08-16 20:52:03 UTC) #3
willchan no longer on Chromium
LGTM
9 years, 4 months ago (2011-08-16 20:54:32 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-17 00:01:09 UTC) #5
Change committed as 97061

Powered by Google App Engine
This is Rietveld 408576698