Issue 7658017: Revert 96974 - Remove mock_ffmpeg and update media unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7658017: Revert 96974 - Remove mock_ffmpeg and update media unittests. (Closed)

Created:
9 years, 4 months ago by rvargas (doing something else)

Modified:
9 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 96974 - Remove mock_ffmpeg and update media unittests. BUG=92429 TEST=BitstreamConverterTest.*, ChunkDemuxerTest.*, FFmpegDemuxerTest.*, FFmpegGlueTest.*, FFmpegVideoDecoderTest.*, FFmpegH264BitstreamConverterTest.*, FFmpegVideoDecodeEngineTest.* Review URL: http://codereview.chromium.org/7587012 TBR=acolwell@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96977

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+967 lines, -486 lines)			Patch
M	media/base/media.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	media/base/media_posix.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	media/base/media_win.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
A +	media/base/mock_ffmpeg.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	media/base/mock_ffmpeg.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	media/base/run_all_unittests.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download
D	media/base/test_data_util.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	media/base/test_data_util.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	media/ffmpeg/ffmpeg_common.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/filters/bitstream_converter.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	media/filters/bitstream_converter_unittest.cc	View	2 chunks	+92 lines, -72 lines	0 comments	Download
M	media/filters/chunk_demuxer_unittest.cc	View	6 chunks	+94 lines, -6 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	14 chunks	+502 lines, -179 lines	0 comments	Download
M	media/filters/ffmpeg_glue.h	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	media/filters/ffmpeg_glue.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	media/filters/ffmpeg_glue_unittest.cc	View	7 chunks	+18 lines, -18 lines	0 comments	Download
M	media/filters/ffmpeg_h264_bitstream_converter_unittest.cc	View	6 chunks	+88 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	media/media.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/video/ffmpeg_video_decode_engine.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	media/video/ffmpeg_video_decode_engine.cc	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	media/video/ffmpeg_video_decode_engine_unittest.cc	View	10 chunks	+137 lines, -89 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages