tools/gyp/v8.gyp - Issue 7658011: GYP fixes: -Werror, snapshot.log, want_separate_host_toolset detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/v8.gyp

Issue 7658011: GYP fixes: -Werror, snapshot.log, want_separate_host_toolset detection (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/v8.gyp

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp

index e755fcb926b5b47e1a73db99c172fa418ee3dc18..ff324057d2a6bd8d2d0d667e7fad4ad4a037c57a 100644

--- a/tools/gyp/v8.gyp

+++ b/tools/gyp/v8.gyp

@@ -144,7 +144,6 @@

'Debug': {

'defines': [

'DEBUG',

- '_DEBUG',

'ENABLE_DISASSEMBLER',

'V8_ENABLE_CHECKS',

'OBJECT_PRINT',

@@ -372,7 +371,10 @@

'<(INTERMEDIATE_DIR)/snapshot.cc',

'variables': {

- 'mksnapshot_flags': [],

+ 'mksnapshot_flags': [

+ '--log-snapshot-positions',

+ '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',

+ ],

'conditions': [

['v8_target_arch=="arm"', {

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »