Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 7658008: Fix issue with prototype of WeakMap constructor. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger
Modified:
9 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix issue with prototype of WeakMap constructor. The WeakMap constructor didn't have a unique prototype, so it shared one with Object. All WeakMap functions (including "get" and "set") were installed on that prototype. R=rossberg@chromium.org BUG=v8:1617 TEST=mjsunit/harmony/weakmaps Committed: http://code.google.com/p/v8/source/detail?r=8941

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added more regression tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/weakmap.js View 2 chunks +8 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/weakmaps.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
9 years, 4 months ago (2011-08-16 10:54:28 UTC) #1
rossberg
http://codereview.chromium.org/7658008/diff/1/test/mjsunit/harmony/weakmaps.js File test/mjsunit/harmony/weakmaps.js (right): http://codereview.chromium.org/7658008/diff/1/test/mjsunit/harmony/weakmaps.js#newcode144 test/mjsunit/harmony/weakmaps.js:144: assertFalse(WeakMap.prototype === Object.prototype); Could you also add a couple ...
9 years, 4 months ago (2011-08-16 11:14:19 UTC) #2
Michael Starzinger
Added new patch set. http://codereview.chromium.org/7658008/diff/1/test/mjsunit/harmony/weakmaps.js File test/mjsunit/harmony/weakmaps.js (right): http://codereview.chromium.org/7658008/diff/1/test/mjsunit/harmony/weakmaps.js#newcode144 test/mjsunit/harmony/weakmaps.js:144: assertFalse(WeakMap.prototype === Object.prototype); On 2011/08/16 ...
9 years, 4 months ago (2011-08-16 11:53:19 UTC) #3
rossberg
9 years, 4 months ago (2011-08-16 11:58:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698