Issue 7658002: Fix invalid read in the ResourceTracker tests. It wasn't doing the proper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7658002: Fix invalid read in the ResourceTracker tests. It wasn't doing the proper (Closed)

Created:
9 years, 4 months ago by brettw

Modified:
9 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix invalid read in the ResourceTracker tests. It wasn't doing the proper NPObject reference counting and was double-freeing the object. TEST=tools/valgrind/chrome_tests.sh -t test_shell --gtest_filter="ResourceTrackerTest.*" BUG=92279 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96948

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -35 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+0 lines, -32 lines	0 comments	Download
	M	webkit/plugins/ppapi/resource_tracker_unittest.cc	View		6 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages