Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5001)

Unified Diff: chrome/browser/mac/closure_blocks_leopard_compat.S

Issue 7657014: Weak-import more symbols in closure_blocks_leopard_compat (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mac/closure_blocks_leopard_compat.S
===================================================================
--- chrome/browser/mac/closure_blocks_leopard_compat.S (revision 96949)
+++ chrome/browser/mac/closure_blocks_leopard_compat.S (working copy)
@@ -7,10 +7,11 @@
#
# This file provides symbols for _NSConcreteGlobalBlock and
# _NSConcreteStackBlock, normally present in libSystem.dylib and provided by
-# by libclosure-38/data.c in Mac OS X 10.6 and later. When using the 10.5 SDK,
-# the symbols are not present. This file's definition can be used with extreme
-# care in an application that needs to use the 10.5 SDK in conjunction with
-# blocks.
+# by libclosure-38/data.c in Mac OS X 10.6 and later. It also provides symbols
+# for various block runtime functions provided by libclosure-38/runtime.c.
+# When using the 10.5 SDK, the symbols are not present. This file's definition
+# can be used with extreme care in an application that needs to use the 10.5
+# SDK in conjunction with blocks.
#
# This file cooperates with the build system to produce a dynamic library
# that, when linked against, causes dependents to look in libSystem for the
@@ -36,8 +37,19 @@
.globl name ## ;\
name ## :
+.text
+
+# Mac OS X 10.6.8 libclosure-38/runtime.c
+
+DEFINE_GLOBAL_SYMBOL(__Block_copy)
+DEFINE_GLOBAL_SYMBOL(__Block_release)
+DEFINE_GLOBAL_SYMBOL(__Block_object_assign)
+DEFINE_GLOBAL_SYMBOL(__Block_object_dispose)
+
.section __DATA,__data
+# Mac OS X 10.6.8 libclosure-38/data.c
+
DEFINE_GLOBAL_SYMBOL(__NSConcreteGlobalBlock)
DEFINE_GLOBAL_SYMBOL(__NSConcreteStackBlock)

Powered by Google App Engine
This is Rietveld 408576698