Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: src/elements.h

Issue 7657011: Implement UnionOfKeys for NonStrictArguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 namespace internal { 34 namespace internal {
35 35
36 // Abstract base class for handles that can operate on objects with differing 36 // Abstract base class for handles that can operate on objects with differing
37 // ElementsKinds. 37 // ElementsKinds.
38 class ElementsAccessor { 38 class ElementsAccessor {
39 public: 39 public:
40 ElementsAccessor() { } 40 ElementsAccessor() { }
41 virtual ~ElementsAccessor() { } 41 virtual ~ElementsAccessor() { }
42 virtual MaybeObject* GetWithReceiver(JSObject* obj, 42 virtual MaybeObject* GetWithReceiver(JSObject* obj,
43 Object* receiver, 43 Object* receiver,
44 uint32_t index) = 0; 44 uint32_t key) = 0;
45 45
46 virtual MaybeObject* Delete(JSObject* obj, 46 virtual MaybeObject* Delete(JSObject* obj,
47 uint32_t index, 47 uint32_t key,
48 JSReceiver::DeleteMode mode) = 0; 48 JSReceiver::DeleteMode mode) = 0;
49 49
50 virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from, 50 virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from,
51 FixedArray* to) = 0; 51 FixedArray* to) = 0;
52 52
53 // Returns a shared ElementsAccessor for the specified ElementsKind. 53 // Returns a shared ElementsAccessor for the specified ElementsKind.
54 static ElementsAccessor* ForKind(JSObject::ElementsKind elements_kind) { 54 static ElementsAccessor* ForKind(JSObject::ElementsKind elements_kind) {
55 ASSERT(elements_kind < JSObject::kElementsKindCount); 55 ASSERT(elements_kind < JSObject::kElementsKindCount);
56 return elements_accessors_[elements_kind]; 56 return elements_accessors_[elements_kind];
57 } 57 }
58 58
59 static ElementsAccessor* ForArray(FixedArrayBase* array);
60
59 static void InitializeOncePerProcess(); 61 static void InitializeOncePerProcess();
60 62
63 protected:
64 friend class NonStrictArgumentsElementsAccessor;
65
66 // TODO(danno): GetElement should be merged with GetWithReceiver.
67 virtual MaybeObject* GetElement(FixedArrayBase* backing_store,
68 uint32_t key) = 0;
69
70 virtual uint32_t GetCapacity(FixedArrayBase* backing_store) = 0;
71
72 virtual bool HasElementAtIndex(FixedArrayBase* backing_store,
73 uint32_t index) = 0;
74
75 // Element handlers distinguish between indexes and keys when the manipulate
76 // elements. Indexes refer to elements in terms of their location in the
77 // underlying storage's backing store representation, and are between 0
78 // GetCapacity. Keys refer to elements in terms of the value that would be
79 // specific in JavaScript to access the element. In most implementations, keys
80 // are equivalent to indexes, and GetKeyForIndex returns the same value it is
81 // passed. In the NumberDictionary ElementsAccessor, GetKeyForIndex maps the
82 // index to a key using the KeyAt method on the NumberDictionary.
83 virtual uint32_t GetKeyForIndex(FixedArrayBase* backing_store,
84 uint32_t index) = 0;
85
61 private: 86 private:
62 static ElementsAccessor** elements_accessors_; 87 static ElementsAccessor** elements_accessors_;
63 88
64 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor); 89 DISALLOW_COPY_AND_ASSIGN(ElementsAccessor);
65 }; 90 };
66 91
67 } } // namespace v8::internal 92 } } // namespace v8::internal
68 93
69 #endif // V8_ELEMENTS_H_ 94 #endif // V8_ELEMENTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698