Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 7657005: Roll ffmpeg/libvpx deps to switch to ffvp8. (Closed)

Created:
9 years, 4 months ago by scherkus (not reviewing)
Modified:
9 years, 4 months ago
Reviewers:
Wez, Alpha Left Google
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Roll ffmpeg/libvpx deps to switch to ffvp8. BUG=50811 TEST=remoting_unittests, media_unittests, layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97421

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : new libvpx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M DEPS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/simple_host_process.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 chunks +1 line, -8 lines 0 comments Download
M remoting/run_all_unittests.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
wez/hclam: review Background: http://codereview.chromium.org/7659006/ I build all targets in remoting.gyp and everything seems to link ...
9 years, 4 months ago (2011-08-16 04:45:47 UTC) #1
Alpha Left Google
LGTM. Looks great to me! :)
9 years, 4 months ago (2011-08-16 10:26:29 UTC) #2
Wez
LGTM with one comment. http://codereview.chromium.org/7657005/diff/1/remoting/host/simple_host_process.cc File remoting/host/simple_host_process.cc (right): http://codereview.chromium.org/7657005/diff/1/remoting/host/simple_host_process.cc#newcode280 remoting/host/simple_host_process.cc:280: PathService::Get(base::DIR_MODULE, &media_module_path); This can go, ...
9 years, 4 months ago (2011-08-17 00:54:07 UTC) #3
scherkus (not reviewing)
9 years, 4 months ago (2011-08-17 02:59:35 UTC) #4
thanks!

http://codereview.chromium.org/7657005/diff/1/remoting/host/simple_host_proce...
File remoting/host/simple_host_process.cc (right):

http://codereview.chromium.org/7657005/diff/1/remoting/host/simple_host_proce...
remoting/host/simple_host_process.cc:280: PathService::Get(base::DIR_MODULE,
&media_module_path);
On 2011/08/17 00:54:07, Wez wrote:
> This can go, too; we only fetch the module directory to pass to
> InitializeMediaLibrary().

Done.

Powered by Google App Engine
This is Rietveld 408576698