chrome/browser/mac/master_prefs.h - Issue 7655056: Enable brand codes and master preferences on the Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/mac/master_prefs.h

Issue 7655056: Enable brand codes and master preferences on the Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: limit Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MAC_MASTER_PREFS_H_

	6 #define CHROME_BROWSER_MAC_MASTER_PREFS_H_

	7 #pragma once

	8

	9 #include "base/file_path.h"

	10

	11 namespace master_prefs {

	12

	13 // Returns the path to the master preferences file.
	Mark Mentovai 2011/08/25 13:35:08 Specify in the comment: • that this might return Specify in the comment: • that this might return an empty FilePath • that the path returned might not exist There’s no need to really go into detail in this comment or in the one in the other file the specific conditions under which this might return an empty file or path to a nonexistent file. It’s sufficient to merely document that this might happen. Avi (use Gerrit) 2011/08/25 15:24:52 Done. Show quoted text On 2011/08/25 13:35:08, Mark Mentovai wrote: > Specify in the comment: > • that this might return an empty FilePath > • that the path returned might not exist > > There’s no need to really go into detail in this comment or in the one in the > other file the specific conditions under which this might return an empty file > or path to a nonexistent file. It’s sufficient to merely document that this > might happen. Done. Avi (use Gerrit) 2011/08/25 15:24:52 Done. Show quoted text On 2011/08/25 13:35:08, Mark Mentovai wrote: > Specify in the comment: > • that this might return an empty FilePath > • that the path returned might not exist > > There’s no need to really go into detail in this comment or in the one in the > other file the specific conditions under which this might return an empty file > or path to a nonexistent file. It’s sufficient to merely document that this > might happen. Done.
	14 FilePath MasterPrefsPath();

	15

	16 } // namespace master_prefs

	17

	18 #endif // CHROME_BROWSER_MAC_MASTER_PREFS_H_

OLD	NEW

« chrome/browser/mac/keystone_glue.h ('K') | « chrome/browser/mac/keystone_glue.mm ('k') | chrome/browser/mac/master_prefs.mm » ('j') | no next file with comments »