Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: libvpx/source/libvpx/vpx_ports/x86_abi_support.asm

Issue 7655050: Define PRIVATE and add it to all global symbols so we don't export assembly functions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party
Patch Set: added patch Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « libvpx/source/libvpx/vpx_ports/emms.asm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libvpx/source/libvpx/vpx_ports/x86_abi_support.asm
diff --git a/libvpx/source/libvpx/vpx_ports/x86_abi_support.asm b/libvpx/source/libvpx/vpx_ports/x86_abi_support.asm
index be64cd7c708020a09a726a655c4b8e86e77efb75..49ff0091e72272af9d3c07a05a78cce643e22697 100644
--- a/libvpx/source/libvpx/vpx_ports/x86_abi_support.asm
+++ b/libvpx/source/libvpx/vpx_ports/x86_abi_support.asm
@@ -92,6 +92,28 @@
%define sym(x) _ %+ x
%endif
+
+; PRIVATE
+; Macro for the attribute to hide a global symbol for the target ABI.
+;
+; Chromium doesn't like exported global symbols due to symbol clashing with
+; plugins among other things.
+;
+; Requires Chromium's patched copy of yasm:
+; http://src.chromium.org/viewvc/chrome?view=rev&revision=73761
+; http://www.tortall.net/projects/yasm/ticket/236
+;
+%ifidn __OUTPUT_FORMAT__,elf32
+%define PRIVATE :hidden
+%elifidn __OUTPUT_FORMAT__,elf64
+%define PRIVATE :hidden
+%elifidn __OUTPUT_FORMAT__,x64
+%define PRIVATE
+%else
+%define PRIVATE :private_extern
+%endif
+
+
; arg()
; Return the address specification of the given argument
;
« no previous file with comments | « libvpx/source/libvpx/vpx_ports/emms.asm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698