Linux: allow linking directly with Kerberos instead of using dlopen.

net/http/mock_gssapi_library_posix.cc

Index: net/http/mock_gssapi_library_posix.cc
diff --git a/net/http/mock_gssapi_library_posix.cc b/net/http/mock_gssapi_library_posix.cc
index 5ae472102c69ab722a0f099d82b6df6ab73f69d6..6d44729e34f035e6127bd0917436f165a1628bd2 100644
--- a/net/http/mock_gssapi_library_posix.cc
+++ b/net/http/mock_gssapi_library_posix.cc
@@ -7,7 +7,6 @@
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
-#include "net/third_party/gssapi/gssapi.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
@@ -279,7 +278,7 @@ OM_uint32 MockGSSAPILibrary::import_name(
   // Save the data.
   output->name = BufferToString(input_name_buffer);
   CopyOid(&output->name_type, input_name_type);
-  *output_name = output;
+  *output_name = reinterpret_cast<gss_name_t>(output);

[cbentzel, 2011/08/18 21:21:17]

Not a bad thing - but was this needed? 

The gssapi.h header in net/third_party has it defined as a void*, and casts from
void* to other types are allowed.

Also, this may need to be a static_cast rather than a reinterpret_cast

http://stackoverflow.com/questions/310451/should-i-use-static-cast-or-reinter...

[Paweł Hajdan Jr., 2011/08/18 23:30:32]

when using the system header static_cast doesn't work:

net/http/mock_gssapi_library_posix.cc:281: error: invalid static_cast from type
‘net::test::GssNameMockImpl*’ to type ‘gss_name_struct*’

[cbentzel, 2011/08/19 12:22:35]

Ah, so gss_name_t is no longer a void* in the system gssapi.h you are building
on.

This is probably OK. I believe reinterpret_cast is still OK here. 

 
   return GSS_S_COMPLETE;
 }