Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 7655017: Improve memory usage of receiver type feedback. (Closed)

Created:
9 years, 4 months ago by Vitaly Repeshko
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve memory usage of receiver type feedback. Some AST nodes (Property, Call, etc.) store either a list of receiver types or a monomorphic receiver type. This patch merges the two fields using a small pointer list. GetMonomorphicReceiverType() is now a purely convenience function returning the first and only recorded type. This saves about 500K (of about 39M) on average when compiling V8 benchmark as measured by a simple patch adding a zone allocation counter (https://gist.github.com/1149397). R=kmillikin@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8993

Patch Set 1 #

Patch Set 2 : ReceiverTypeList -> SmallMapList #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -109 lines) Patch
M src/ast.h View 1 14 chunks +45 lines, -28 lines 1 comment Download
M src/ast.cc View 6 chunks +23 lines, -24 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 7 chunks +10 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/small-pointer-list.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/stub-cache.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/type-info.h View 1 3 chunks +20 lines, -12 lines 0 comments Download
M src/type-info.cc View 1 3 chunks +21 lines, -24 lines 0 comments Download
M src/zone.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
9 years, 4 months ago (2011-08-17 12:52:02 UTC) #1
Vitaly Repeshko
9 years, 4 months ago (2011-08-17 12:52:44 UTC) #2
fschneider
9 years, 4 months ago (2011-08-22 13:38:06 UTC) #3
LGTM.

http://codereview.chromium.org/7655017/diff/2001/src/ast.h
File src/ast.h (right):

http://codereview.chromium.org/7655017/diff/2001/src/ast.h#newcode216
src/ast.h:216: void Reserve(int capacty) { list_.Reserve(capacty); }
capacty -> capacity

Powered by Google App Engine
This is Rietveld 408576698