Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 7655002: Convert the pp::proxy namespace to the ppapi::proxy namespace. (Closed)

Created:
9 years, 4 months ago by brettw
Modified:
9 years, 4 months ago
Reviewers:
bbudge
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert the pp::proxy namespace to the ppapi::proxy namespace. This is more consistent with the stuff in shared_impl, and removes a lot of namespace using goop. Add a unified resource tracker shared between the proxy and the impl. This renames the old ResourceObjectBase to Resource and removes the old PluginResource. It moves the resource tracker from the impl to the shared_impl, and makes the proxy use it. Some things become a little less neat because there's no proxy resource base class. In particular GetDispatcher() is now gone. I considered whether to add a helper base class that provides this function, but decided against it and had individual resource classes implement this when their implementation would find it useful. This is because ultimately I want more of this functionality to move into the shared_impl, and it's easier to do that if there are fewer proxy-specific things in the resources. This changes the way that plugins are added to the tracker. Previously they would only be in the tracker if the plugin had a reference to them, although they could be alive if the impl had a scoped_ptr referencing an object. This actually has the bug that if we then give the resource back to the plugin, it wouldn't be refcounted properly and everything would get confused. Now the tracker tracks all live resource objects whether or not the plugin has a ref. This works basically like the var tracker (it would be nice if the var and resource trackers shared more code, but that would further complicate this already overcomplicated patch). The resource tracker takes an extra ref whenever the plugin has one or more, and otherwise just tracks live resources. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97367

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -831 lines) Patch
M content/browser/renderer_host/pepper_message_filter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/plugin_process_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/plugin_process_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/callback_tracker.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/callback_tracker.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/dispatcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/enter_proxy.h View 6 chunks +10 lines, -10 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 4 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/host_dispatcher_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/host_var_serialization_rules.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/host_var_serialization_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_id.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_proxy.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/mock_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/mock_resource.cc View 2 chunks +2 lines, -5 lines 1 comment Download
M ppapi/proxy/plugin_dispatcher.h View 8 chunks +10 lines, -13 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.h View 4 chunks +12 lines, -15 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_var_serialization_rules.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/plugin_var_serialization_rules.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.h View 4 chunks +8 lines, -9 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 22 chunks +92 lines, -92 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 4 chunks +19 lines, -22 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 14 chunks +51 lines, -50 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_audio_config_proxy.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/ppb_audio_config_proxy.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_broker_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.h View 3 chunks +7 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_buffer_proxy.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M ppapi/proxy/ppb_char_set_proxy.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/ppb_char_set_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_console_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_console_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.h View 2 chunks +17 lines, -17 lines 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_core_proxy.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/ppb_core_proxy.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_crypto_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_crypto_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_cursor_control_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_chooser_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_file_ref_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_file_system_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_file_proxy.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_file_proxy.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_flash_menu_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_flash_menu_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_flash_net_connector_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_flash_net_connector_proxy.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.cc View 5 chunks +6 lines, -11 lines 1 comment Download
M ppapi/proxy/ppb_graphics_2d_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_2d_proxy.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 3 chunks +19 lines, -21 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 2 chunks +5 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_input_event_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_input_event_proxy.cc View 7 chunks +7 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_memory_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_memory_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_opengles2_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_opengles2_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_surface_3d_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_url_request_info_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_url_request_info_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_url_response_info_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_url_response_info_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_url_util_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_url_util_proxy.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_var_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_var_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_var_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_video_capture_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 9 chunks +15 lines, -18 lines 1 comment Download
M ppapi/proxy/ppp_class_proxy.h View 3 chunks +3 lines, -3 lines 1 comment Download
M ppapi/proxy/ppp_class_proxy.cc View 3 chunks +3 lines, -3 lines 1 comment Download
M ppapi/proxy/ppp_graphics_3d_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.h View 3 chunks +6 lines, -7 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_non_thread_safe_ref_count.h View 2 chunks +2 lines, -2 lines 1 comment Download
M ppapi/proxy/proxy_object_var.h View 3 chunks +5 lines, -7 lines 0 comments Download
M ppapi/proxy/proxy_object_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 3 chunks +9 lines, -10 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/serialized_structs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_var.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/serialized_var_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/var_serialization_rules.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/resource_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/tracker_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/ppb_char_set_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_cursor_control_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_find_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/thunk/ppb_font_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_tracker.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Lots of files but basically search and replace, you might want to do the review ...
9 years, 4 months ago (2011-08-16 20:38:35 UTC) #1
bbudge
9 years, 4 months ago (2011-08-16 22:40:48 UTC) #2
A bunch of '2010's in copyright notices, and some 'using' declaration
consistency which is up to you. Otherwise, LGTM. Looks like a nice cleanup.
Whew!

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/callback_tracker.cc
File ppapi/proxy/callback_tracker.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/callback_tracker.cc...
ppapi/proxy/callback_tracker.cc:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/callback_tracker.h
File ppapi/proxy/callback_tracker.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/callback_tracker.h#...
ppapi/proxy/callback_tracker.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/interface_proxy.cc
File ppapi/proxy/interface_proxy.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/interface_proxy.cc#...
ppapi/proxy/interface_proxy.cc:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/mock_resource.cc
File ppapi/proxy/mock_resource.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/mock_resource.cc#ne...
ppapi/proxy/mock_resource.cc:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/plugin_var_serializ...
File ppapi/proxy/plugin_var_serialization_rules.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/plugin_var_serializ...
ppapi/proxy/plugin_var_serialization_rules.h:1: // Copyright (c) 2010 The
Chromium Authors. All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_audio_config_pr...
File ppapi/proxy/ppb_audio_config_proxy.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_audio_config_pr...
ppapi/proxy/ppb_audio_config_proxy.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_char_set_proxy.h
File ppapi/proxy/ppb_char_set_proxy.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_char_set_proxy....
ppapi/proxy/ppb_char_set_proxy.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_core_proxy.h
File ppapi/proxy/ppb_core_proxy.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_core_proxy.h#ne...
ppapi/proxy/ppb_core_proxy.h:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_font_proxy.cc
File ppapi/proxy/ppb_font_proxy.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_font_proxy.cc#n...
ppapi/proxy/ppb_font_proxy.cc:22: using ppapi::thunk::PPB_ImageData_API;
Why not also declare PPB_Font_API and PPB_Font_Function_API here? They're
explicitly qualified below.

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_video_decoder_p...
File ppapi/proxy/ppb_video_decoder_proxy.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppb_video_decoder_p...
ppapi/proxy/ppb_video_decoder_proxy.cc:21: using
ppapi::thunk::PPB_VideoDecoder_API;
There are lots of explicitly qualified 'thunk' types in the code below that
could be declared here.

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppp_class_proxy.cc
File ppapi/proxy/ppp_class_proxy.cc (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppp_class_proxy.cc#...
ppapi/proxy/ppp_class_proxy.cc:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppp_class_proxy.h
File ppapi/proxy/ppp_class_proxy.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/ppp_class_proxy.h#n...
ppapi/proxy/ppp_class_proxy.h:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
2011

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/proxy_non_thread_sa...
File ppapi/proxy/proxy_non_thread_safe_ref_count.h (right):

http://codereview.chromium.org/7655002/diff/1/ppapi/proxy/proxy_non_thread_sa...
ppapi/proxy/proxy_non_thread_safe_ref_count.h:1: // Copyright (c) 2010 The
Chromium Authors. All rights reserved.
2011

Powered by Google App Engine
This is Rietveld 408576698