Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 7654001: Remove an unnecessary argument. (Closed)

Created:
9 years, 4 months ago by Peter Kasting
Modified:
9 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Remove an unnecessary argument. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
9 years, 4 months ago (2011-08-15 22:09:00 UTC) #1
oshima
9 years, 4 months ago (2011-08-16 01:16:12 UTC) #2
LGTM

On Mon, Aug 15, 2011 at 3:09 PM, <pkasting@chromium.org> wrote:

> Reviewers: oshima,
>
> Description:
> Remove an unnecessary argument.
>
> BUG=none
> TEST=none
>
> Please review this at
http://codereview.chromium.**org/7654001/<http://codereview.chromium.org/7654...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/ui/views/**omnibox/omnibox_view_views.h
>  M     chrome/browser/ui/views/**omnibox/omnibox_view_views.cc
>
>
> Index: chrome/browser/ui/views/**omnibox/omnibox_view_views.cc
> ==============================**==============================**=======
> --- chrome/browser/ui/views/**omnibox/omnibox_view_views.cc
> (revision 96793)
> +++ chrome/browser/ui/views/**omnibox/omnibox_view_views.cc       (working
> copy)
> @@ -146,7 +146,7 @@
>                                    bool popup_window_mode,
>                                    views::View* location_bar)
>     : model_(new AutocompleteEditModel(this, controller, profile)),
> -      popup_view_(CreatePopupView(**profile, location_bar)),
> +      popup_view_(CreatePopupView(**location_bar)),
>       controller_(controller),
>       toolbar_model_(toolbar_model),
>       command_updater_(command_**updater),
> @@ -642,8 +642,8 @@
>   // And Go system uses.
>   string16 text = GetText();
>   url_parse::Component scheme, host;
> -  AutocompleteInput::**ParseForEmphasizeComponents(
> -      text, model_->GetDesiredTLD(), &scheme, &host);
> +  AutocompleteInput::**ParseForEmphasizeComponents(**text,
> model_->GetDesiredTLD(),
> +                                                 &scheme, &host);
>   const bool emphasize = model_->CurrentTextIsURL() && (host.len > 0);
>   SkColor base_color = emphasize ? kFadedTextColor : kNormalTextColor;
>   ApplyURLStyle(textfield_, 0, text.length(), base_color, false);
> @@ -693,7 +693,6 @@
>  }
>
>  AutocompletePopupView* OmniboxViewViews::**CreatePopupView(
> -    Profile* profile,
>     View* location_bar) {
>  #if defined(TOUCH_UI)
>   typedef TouchAutocompletePopupContents**View AutocompleteContentsView;
> Index: chrome/browser/ui/views/**omnibox/omnibox_view_views.h
> ==============================**==============================**=======
> --- chrome/browser/ui/views/**omnibox/omnibox_view_views.h
>  (revision 96793)
> +++ chrome/browser/ui/views/**omnibox/omnibox_view_views.h        (working
> copy)
> @@ -156,8 +156,7 @@
>   // Selects the text given by |caret| and |end|.
>   void SelectRange(size_t caret, size_t end);
>
> -  AutocompletePopupView* CreatePopupView(Profile* profile,
> -                                         View* location_bar);
> +  AutocompletePopupView* CreatePopupView(View* location_bar);
>
>   views::Textfield* textfield_;
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698